Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade UI dependencies to fix some problem. #11439

Merged
merged 1 commit into from Nov 28, 2023

Conversation

KomachiSion
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@KomachiSion KomachiSion added the dependencies Pull requests that update a dependency file label Nov 28, 2023
@KomachiSion KomachiSion added the javascript Pull requests that update Javascript code label Nov 28, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #11439 (04e6e3d) into develop (2151756) will increase coverage by 0.10%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #11439      +/-   ##
=============================================
+ Coverage      61.63%   61.74%   +0.10%     
- Complexity      6824     6827       +3     
=============================================
  Files           1060     1060              
  Lines          31408    31408              
  Branches        3250     3250              
=============================================
+ Hits           19359    19393      +34     
+ Misses         10700    10670      -30     
+ Partials        1349     1345       -4     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2151756...04e6e3d. Read the comment docs.

@KomachiSion KomachiSion merged commit bb7a6ce into alibaba:develop Nov 28, 2023
7 checks passed
@KomachiSion KomachiSion deleted the develop-ui-upgrade branch November 28, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants