Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #11835 #11838

Merged
merged 1 commit into from
Mar 18, 2024
Merged

fix #11835 #11838

merged 1 commit into from
Mar 18, 2024

Conversation

JianweiWang
Copy link
Collaborator

fix #11835

update service's lastUpdatedTime when snapshot loaded.

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.91%. Comparing base (038420c) to head (54fb07d).
Report is 162 commits behind head on develop.

Files with missing lines Patch % Lines
...naming/core/v2/metadata/NamingMetadataManager.java 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #11838      +/-   ##
=============================================
- Coverage      67.91%   67.91%   -0.01%     
+ Complexity      8915     8914       -1     
=============================================
  Files           1236     1236              
  Lines          40458    40459       +1     
  Branches        4292     4292              
=============================================
- Hits           27479    27478       -1     
- Misses         11002    11004       +2     
  Partials        1977     1977              
Files with missing lines Coverage Δ
...naming/core/v2/metadata/NamingMetadataManager.java 79.74% <0.00%> (-1.03%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 038420c...54fb07d. Read the comment docs.

@KomachiSion KomachiSion merged commit b79d585 into develop Mar 18, 2024
7 checks passed
@KomachiSion KomachiSion added kind/bug Category issues or prs related to bug. area/Naming labels Mar 18, 2024
@KomachiSion KomachiSion added this to the 2.4.0 milestone Mar 18, 2024
cxhello pushed a commit to cxhello/nacos that referenced this pull request Mar 20, 2024
@KomachiSion KomachiSion modified the milestones: 2.4.0, 2.3.2 Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Naming kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A Service was removed after server restarted
3 participants