Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #12133] upgrade module naocs-core from junit4 to junit5 #12134

Merged
merged 1 commit into from
May 31, 2024

Conversation

shalk
Copy link
Contributor

@shalk shalk commented May 24, 2024

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix #12133

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.73%. Comparing base (6bee5c4) to head (f2ce3b1).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12134      +/-   ##
=============================================
- Coverage      68.77%   68.73%   -0.05%     
  Complexity      9127     9127              
=============================================
  Files           1252     1252              
  Lines          40886    40907      +21     
  Branches        4340     4340              
=============================================
- Hits           28119    28117       -2     
- Misses         10757    10776      +19     
- Partials        2010     2014       +4     

see 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bee5c4...f2ce3b1. Read the comment docs.

Copy link
Collaborator

@KomachiSion KomachiSion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不修改grpc-testing的话,是无法改为junit5吗?

<groupId>io.grpc</groupId>
<artifactId>grpc-testing</artifactId>
<groupId>com.asarkar.grpc</groupId>
<artifactId>grpc-test</artifactId>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个产品的开源协议是什么?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

另外有没有长期维护的情况?

Copy link
Contributor Author

@shalk shalk May 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license is Apache-2.0 license

Yes, test lib looks stable. Test Lib author is active

grpc-testing can not upgrade to junit4

@KomachiSion KomachiSion merged commit 04f9b86 into alibaba:develop May 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[test] module core upgrade to junit5
3 participants