Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#12563] Fix paramchecker invalid bug #12564

Merged

Conversation

KomachiSion
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Fix #12563.

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@KomachiSion KomachiSion added the kind/bug Category issues or prs related to bug. label Aug 28, 2024
@KomachiSion KomachiSion added this to the 2.4.2 milestone Aug 28, 2024
@KomachiSion KomachiSion changed the title [ISSUE#12563] Develop fix paramchecker invalid bug [ISSUE#12563] Fix paramchecker invalid bug Aug 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.65%. Comparing base (a9a0df2) to head (166949d).
Report is 18 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12564      +/-   ##
=============================================
+ Coverage      69.62%   69.65%   +0.02%     
- Complexity      9398     9399       +1     
=============================================
  Files           1275     1275              
  Lines          41161    41161              
  Branches        4366     4366              
=============================================
+ Hits           28657    28669      +12     
+ Misses         10428    10415      -13     
- Partials        2076     2077       +1     
Files with missing lines Coverage Δ
...baba/nacos/core/paramcheck/CheckConfiguration.java 100.00% <100.00%> (+75.00%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9a0df2...166949d. Read the comment docs.

@KomachiSion KomachiSion merged commit 2d22066 into alibaba:develop Aug 28, 2024
7 checks passed
@KomachiSion KomachiSion deleted the develop-fix-paramchecker-invalid-bug branch August 28, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameter check is invalid in 2.4.0 and 2.4.1
2 participants