Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 12569 #12571

Closed
wants to merge 25 commits into from
Closed

Conversation

huangkemingyyds
Copy link
Contributor

@huangkemingyyds huangkemingyyds commented Aug 31, 2024

#12569

Change the checklist existence check to use ‘count’.

yanlinly and others added 23 commits June 5, 2020 16:31
Merge develop to master, upgrade version to 1.4.2
Merge develop into master to release 2.2.0
@CLAassistant
Copy link

CLAassistant commented Aug 31, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 4 committers have signed the CLA.

✅ KomachiSion
✅ huangkemingyyds
❌ yanlinly
❌ xuande
You have signed the CLA already but the status is still pending? Let us recheck it.

@huangkemingyyds huangkemingyyds changed the title ifx Issue 12569 fix Issue 12569 Aug 31, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.64%. Comparing base (209dfe8) to head (b8cd2fd).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #12571   +/-   ##
==========================================
  Coverage      69.63%   69.64%           
+ Complexity      9399     9398    -1     
==========================================
  Files           1275     1275           
  Lines          41161    41161           
  Branches        4366     4366           
==========================================
+ Hits           28663    28665    +2     
+ Misses         10422    10418    -4     
- Partials        2076     2078    +2     
Files with missing lines Coverage Δ
...epository/EmbeddedNamespacePersistServiceImpl.java 100.00% <100.00%> (ø)
...epository/ExternalNamespacePersistServiceImpl.java 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 209dfe8...b8cd2fd. Read the comment docs.

@KomachiSion
Copy link
Collaborator

The PR is invalid beacuse include others commit

@KomachiSion KomachiSion closed this Sep 2, 2024
@KomachiSion KomachiSion added the status/invalid This doesn't seem right label Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants