Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce unnecessary InetAddress.getLocalHost() calls #4095

Merged
merged 2 commits into from
Nov 3, 2020

Conversation

wangweizZZ
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

#4093

Brief changelog

IdGeneratorManager.register() calls the InetAddress.getLocalHost() method multiple times, and this is time-consuming. Using InetUtils.getSelfIP() replacement has speeded up the startup

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@KomachiSion KomachiSion added this to the 1.4.1 milestone Oct 30, 2020
@KomachiSion
Copy link
Collaborator

This PR will merge after 1.4.0 released

@@ -70,28 +71,28 @@
// 工作机器ID最大值1024
private static final long WORKER_ID_MAX_VALUE = 1024L;

private long workerId;
private static long workerId;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not use static variables, which are required for instance variables

@chuntaojun chuntaojun merged commit 1282445 into alibaba:develop Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants