Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: adjustment for builtin plugin directories #46

Merged
merged 7 commits into from
Mar 20, 2020

Conversation

rickycao-qy
Copy link
Collaborator

This PR includes:

  • move plugins-related folder into subfolder 'plugins'
  • remove prefix 'pipcook-plugins' for plugin folders
  • fix tjs-node-gpu verison

@yorkie Please have a review please

@yorkie
Copy link
Member

yorkie commented Mar 20, 2020

And how about creating a shared tsconfig.json for all built-in plugins?

@rickycao-qy
Copy link
Collaborator Author

And how about creating a shared tsconfig.json for all built-in plugins?

For lerna practise, I follow some guides online. I guess it's recommended to create separate tsconfig for each package and extends a common tsconfig since package should be regarded as independent pacakge? How do you think

@yorkie
Copy link
Member

yorkie commented Mar 20, 2020

Thanks for the guideline link, and how about tweaking our tsconfig inheritance as the following:

(tsconfig for independent plugin)
-------------------------------
tsconfig for common plugin
-------------------------------
tsconfig for root

And there are some notes for the above:

  • independent plugin configuration is optional, but "extend" is required.
  • common plugin config could be also used for our non-official plugin developer in the future.

@yorkie yorkie changed the title Daily/plugin move meta: adjustment for builtin plugin directories Mar 20, 2020
@yorkie yorkie added meta Project suggestion and discussion plugin Pipcook plugin addition, bug report and changes labels Mar 20, 2020
@rickycao-qy rickycao-qy merged commit 225037d into master Mar 20, 2020
@rickycao-qy rickycao-qy deleted the daily/plugin_move branch March 20, 2020 10:33
gindis pushed a commit to gindis/pipcook that referenced this pull request Sep 11, 2020
* rename plugins

* move plugins into plugin folder

* change package.json and tfconfig.json accordingly

* fix eof

* fix .npmignore for python-node

* fix package-lock rm

* fix package-lock rm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Project suggestion and discussion plugin Pipcook plugin addition, bug report and changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants