Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipboard: add show cases to pipboard #52

Merged
merged 20 commits into from
Mar 24, 2020
Merged

pipboard: add show cases to pipboard #52

merged 20 commits into from
Mar 24, 2020

Conversation

rickycao-qy
Copy link
Collaborator

This PR includes:

  • decouple server part of pipboard from pipcook-core. Before it's using fastify inside pipcook-core. Now I have moved the server into 'pipcook-board-server' and build on top of Egg.js of Alibaba
  • add two show cases to the home of pipboard
  • optimize pipcook-cli to supoort pipboard and also do some optimization in cli tool
  • add 'who's using it' part to Readme and a guide to try MNIST example

Please have a review pls, Thank you @yorkie

@rickycao-qy rickycao-qy added enhancement New feature or request core pipcook-core module cli pipboard Pipboard labels Mar 23, 2020
@rickycao-qy rickycao-qy requested a review from yorkie March 23, 2020 07:43
yorkie
yorkie suggested changes Mar 23, 2020
View reviewed changes
Copy link
Member

@yorkie yorkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaves some reviews, great jobs!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/zh-cn/tutorials/get-started-with-pipeline-api.md Outdated Show resolved Hide resolved
example/pipeline-example/pipeline-mnist-image-classification.js Outdated Show resolved Hide resolved
packages/pipcook-board-server/README.md Outdated Show resolved Hide resolved
packages/pipcook-board-server/app/utils/index.ts Show resolved Hide resolved
packages/pipcook-cli/assets/example/pipeline-example/pipeline-mnist-image-classification.js Outdated Show resolved Hide resolved
@yorkie
Copy link
Member

yorkie commented Mar 23, 2020

And the CI should be fixed, too :)

@rickycao-qy
Copy link
Collaborator Author

@yorkie Thank you for review. Have fixed the codes accordingly.

@yorkie
Copy link
Member

yorkie commented Mar 23, 2020

@yorkie Thank you for review. Have fixed the codes accordingly.

See https://github.com/alibaba/pipcook/pull/52/files#r396464928, this might be the last what I have concerned, otherwise SGTM now :)

@yorkie yorkie changed the title add show cases to pipboard pipboard: add show cases to pipboard Mar 23, 2020
yorkie
yorkie approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@yorkie yorkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green.

@yorkie yorkie merged commit 13a1d53 into master Mar 24, 2020
@yorkie yorkie deleted the daily/init_optimize branch March 24, 2020 02:27
@yorkie yorkie mentioned this pull request Apr 2, 2020
Closed
gindis pushed a commit to gindis/pipcook that referenced this pull request Sep 11, 2020
@rickycao-qy
pipboard: add show cases to pipboard (alibaba#52)
ff0eaac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorkie yorkie yorkie approved these changes

Assignees
No one assigned
Labels
cli core pipcook-core module enhancement New feature or request pipboard Pipboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rickycao-qy @yorkie