Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[=] Added parameter descriptions #291

Merged
merged 3 commits into from
Mar 15, 2023
Merged

[=] Added parameter descriptions #291

merged 3 commits into from
Mar 15, 2023

Conversation

derekwin
Copy link
Contributor

Update parameter descriptions in Testing-zh.md, test_client.c test_server.c.

@ruiqizhou ruiqizhou self-requested a review March 14, 2023 08:59
@ruiqizhou ruiqizhou added the 📖 documentation Improvements or additions to documentation label Mar 14, 2023
@ruiqizhou ruiqizhou changed the title [~] Added parameter descriptions [=] Added parameter descriptions Mar 14, 2023
ruiqizhou
ruiqizhou requested changes Mar 14, 2023
View reviewed changes
docs/docs-zh/Testing-zh.md Outdated Show resolved Hide resolved
tests/test_client.c Outdated Show resolved Hide resolved
derekwin and others added 2 commits March 14, 2023 17:50
@derekwin @ruiqizhou
Update tests/test_client.c
6e192f9 
Co-authored-by: Zhou <dangdang.zrq@alibaba-inc.com>
@derekwin @ruiqizhou
Update docs/docs-zh/Testing-zh.md
fa84ce1 
Co-authored-by: Zhou <dangdang.zrq@alibaba-inc.com>
@derekwin derekwin requested a review from ruiqizhou March 14, 2023 10:17
@CLAassistant
Copy link

CLAassistant commented Mar 14, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

ruiqizhou
ruiqizhou approved these changes Mar 15, 2023
View reviewed changes
Copy link
Collaborator

@ruiqizhou ruiqizhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks!

@ruiqizhou ruiqizhou merged commit 9f17e54 into alibaba:main Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruiqizhou ruiqizhou ruiqizhou approved these changes

Assignees
No one assigned
Labels
📖 documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derekwin @CLAassistant @ruiqizhou