Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle messages with custom error code in error_reply #325

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

pkierski
Copy link
Contributor

Redis treats first "word" of error message as custom error code, So redis.error_reply("foo bar") returns "-foo bar" but not "-ERR foo bar".
This is a problem for testing application which relies on exact error message returned by Lua script.

@alicebob
Copy link
Owner

thanks for the PR, looks good. So many werid edge cases in redis :)
Can you squash the commits? If I do that you won't get credits.

@pkierski
Copy link
Contributor Author

Squashed.

@alicebob alicebob merged commit 1be35fa into alicebob:master Apr 24, 2023
@alicebob
Copy link
Owner

great, thanks for the fix. Will make it a proper version in a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants