Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hacky fix to remove warning at boot #152

Merged
1 commit merged into from
Aug 10, 2022
Merged

Hacky fix to remove warning at boot #152

1 commit merged into from
Aug 10, 2022

Conversation

ghost
Copy link

@ghost ghost commented Aug 9, 2022

Scope

Workaround for -help flag causing warnings in logs.

Why?

Logs should be clean.

Follow on

We should revisit the entirety of our configuration to leverage viper or some other mechanism that requires less manual work.

@ghost ghost self-requested a review as a code owner August 9, 2022 19:51
@github-actions github-actions bot added the go Pull requests that update Go code label Aug 9, 2022
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #152 (40569ee) into main (50d49c0) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
- Coverage   53.26%   53.26%   -0.01%     
==========================================
  Files         343      343              
  Lines       44520    44520              
  Branches      360      360              
==========================================
- Hits        23714    23713       -1     
- Misses      18315    18319       +4     
+ Partials     2491     2488       -3     
Impacted Files Coverage Δ
peering/active.go 83.01% <0.00%> (-0.95%) ⬇️
badgerTrie/smt_merkle_proof.go 69.53% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghost ghost merged commit 6d98b1d into main Aug 10, 2022
@ghost ghost deleted the remove-init-warning branch August 10, 2022 13:04
vtleonardo referenced this pull request in vtleonardo/alicenet Sep 26, 2022
Co-authored-by: Ricardo Pinto <ricardopinto@users.noreply.github.com>
Co-authored-by: stuckDaemon <stuckDaemon@users.noreply.github.com>
Co-authored-by: Leonardo Viana <38760502+vtleonardo@users.noreply.github.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant