Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in more flakes #479

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Adding in more flakes #479

merged 1 commit into from
Nov 10, 2022

Conversation

ghost
Copy link

@ghost ghost commented Nov 9, 2022

Scope

Why?

Breaking CI runs

@ghost ghost self-requested a review as a code owner November 9, 2022 19:05
@github-actions github-actions bot added the go Pull requests that update Go code label Nov 9, 2022
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 82.32% // Head: 53.64% // Decreases project coverage by -28.67% ⚠️

Coverage data is based on head (c8de41a) compared to base (e2bd3b4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #479       +/-   ##
===========================================
- Coverage   82.32%   53.64%   -28.68%     
===========================================
  Files          62      340      +278     
  Lines        2014    42408    +40394     
  Branches      548      548               
===========================================
+ Hits         1658    22751    +21093     
- Misses        356    17220    +16864     
- Partials        0     2437     +2437     
Impacted Files Coverage Δ
crypto/bn256/cloudflare/dkg.go 98.32% <0.00%> (ø)
middleware/ewouldblock.go 0.00% <0.00%> (ø)
layer1/executor/tasks/dkg/gpkj_submission.go 0.00% <0.00%> (ø)
consensus/lstate/fastsync.go 55.06% <0.00%> (ø)
application/objs/txvec.go 58.91% <0.00%> (ø)
consensus/db/rawdb.go 46.41% <0.00%> (ø)
application/indexer/expsize.go 87.12% <0.00%> (ø)
application/indexer/data.go 81.28% <0.00%> (ø)
crypto/bn.go 81.63% <0.00%> (ø)
application/txhandler.go 9.56% <0.00%> (ø)
... and 268 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vtleonardo
Copy link
Contributor

LGTM!

@vtleonardo vtleonardo merged commit 93481e8 into main Nov 10, 2022
@vtleonardo vtleonardo deleted the more-flakes branch November 10, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant