Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ETHDKG delegateCall method and add history of MPKs #500

Merged
merged 11 commits into from
Nov 23, 2022
Merged

Conversation

vtleonardo
Copy link
Contributor

@vtleonardo vtleonardo commented Nov 16, 2022

closes #405

@vtleonardo vtleonardo requested a review from a team as a code owner November 16, 2022 12:56
@vtleonardo vtleonardo marked this pull request as draft November 16, 2022 12:56
@github-actions github-actions bot added javascript Pull requests that update Javascript code solidity labels Nov 16, 2022
@github-actions github-actions bot removed the javascript Pull requests that update Javascript code label Nov 22, 2022
@vtleonardo vtleonardo changed the title WIP: Change ETHDKG delegateCall method Change ETHDKG delegateCall method and add history of MPKs Nov 22, 2022
@github-actions github-actions bot added the go Pull requests that update Go code label Nov 22, 2022
@vtleonardo vtleonardo marked this pull request as ready for review November 22, 2022 13:01
@vtleonardo vtleonardo requested a review from a team as a code owner November 22, 2022 13:01
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 54.38% // Head: 54.37% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (7538301) compared to base (225e477).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #500      +/-   ##
==========================================
- Coverage   54.38%   54.37%   -0.02%     
==========================================
  Files         369      369              
  Lines       42699    42699              
  Branches      599      599              
==========================================
- Hits        23223    23217       -6     
- Misses      17021    17023       +2     
- Partials     2455     2459       +4     
Impacted Files Coverage Δ
...ridge/contracts/InvalidTxConsumptionAccusation.sol 90.00% <ø> (ø)
bridge/contracts/libraries/ethdkg/ETHDKGPhases.sol 87.73% <ø> (ø)
...ridge/contracts/libraries/ethdkg/ETHDKGStorage.sol 100.00% <ø> (ø)
bridge/contracts/ETHDKG.sol 84.42% <100.00%> (ø)
badgerTrie/smt_merkle_proof.go 65.62% <0.00%> (-3.91%) ⬇️
layer1/executor/task_handler.go 76.81% <0.00%> (-1.45%) ⬇️
layer1/executor/task_manager.go 73.51% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Nov 23, 2022
@vtleonardo vtleonardo enabled auto-merge (squash) November 23, 2022 14:18
Copy link
Contributor

@Cr0wn-Gh0ul Cr0wn-Gh0ul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vtleonardo vtleonardo merged commit c443b60 into main Nov 23, 2022
@vtleonardo vtleonardo deleted the fix-ethdkg branch November 23, 2022 15:28
@Cr0wn-Gh0ul
Copy link
Contributor

bridge/contracts/InvalidTxConsumptionAccusation.sol has a todo. Make sure this is visible to the issue / pr that resolves it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code javascript Pull requests that update Javascript code solidity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keeping track of 6 master public keys for ethdkg
3 participants