Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new task to deploy and register lockup #537

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

vtleonardo
Copy link
Contributor

Scope

Add a new hardhat task to deploy and register both Lockup and StakingRounter contracts.

@vtleonardo vtleonardo requested a review from a team as a code owner November 28, 2022 17:54
@github-actions github-actions bot added javascript Pull requests that update Javascript code solidity labels Nov 28, 2022
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 54.35% // Head: 54.37% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (e0673f1) compared to base (154f52d).
Patch coverage: 60.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #537      +/-   ##
==========================================
+ Coverage   54.35%   54.37%   +0.01%     
==========================================
  Files         369      369              
  Lines       42708    42709       +1     
  Branches      599      599              
==========================================
+ Hits        23212    23221       +9     
+ Misses      17037    17030       -7     
+ Partials     2459     2458       -1     
Impacted Files Coverage Δ
bridge/contracts/BonusPool.sol 88.23% <60.00%> (-5.71%) ⬇️
badgerTrie/smt_merkle_proof.go 69.53% <0.00%> (ø)
peering/active.go 83.96% <0.00%> (+0.94%) ⬆️
layer1/executor/task_manager.go 72.53% <0.00%> (+1.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@z-j-lin z-j-lin merged commit f7464ff into alicenet:main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code solidity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants