Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding windows CI on appveyor #41

Merged
merged 19 commits into from
Jun 14, 2018
Merged

Adding windows CI on appveyor #41

merged 19 commits into from
Jun 14, 2018

Conversation

simogasp
Copy link
Member

@simogasp simogasp commented May 30, 2018

  • using boost from appveyor system (1.66)
    • unable to use boost from vcpkg at this time as it sports boost 1.67 which apparently does not work well with any recent nvcc version
      • Fixed by 8d6769f : there was a cuda file that was actually a cpp file
      • it does use boost by vcpkg
  • not using Devil because the default build does not install the header <devil_cpp_wrapper.hpp> which is required for the applications
    • instead it uses the pgmread lib
    • incidentally, made Devil optional on cmake as the fallback on pgmread was already in place
  • using cuda 9.1
  • minor code fix in main.cpp and match.cpp, a range loop and a simplified code to add a path to a vector of string without passing by c_str conversion

@simogasp simogasp changed the title [WIP] Addind windows CI on appveyor Adding windows CI on appveyor Jun 6, 2018
cuda is not necessary for this file
If an include is missing, the compilation will fail instead of having
some preprocessor variables becoming undefined.
So instead of relying on ifdef/ifndef, we rely on 0/1 values.
We use "function define" to ensure that there is no incorrect
ifdef/ifndef usage.
@fabiencastan fabiencastan force-pushed the ciAppveyor branch 2 times, most recently from d164648 to f37b0c0 Compare June 12, 2018 15:15
@fabiencastan fabiencastan merged commit 8dc066e into develop Jun 14, 2018
@fabiencastan fabiencastan deleted the ciAppveyor branch June 14, 2018 10:26
@simogasp simogasp mentioned this pull request Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants