[cmake] windows fixes #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nvcc causing warnings
… causing warnings
this is for vcpkg, the intermediate link step is not propagating correctly these flags. Possible side effect is that the flags are repeated in normal building with VS
the first should be only used for dynamic building
fabiencastan
approved these changes
May 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes for windows. These changes are also meant to comply with the in-progress vcpkg port
microsoft/vcpkg#10979
Most notably:
some fixes to ensure a full static build under windows, the proper linker flags are now correctly propagated
remove unsupported flags for nvcc under MSVC like -fPic and c++11
ci on appveyor now testing release and debug
incidentally it fixes CMake: Demo program not built as PIE #49 by propagating the proper
-pieand-fPIEflags