Skip to content
This repository has been archived by the owner on Oct 4, 2023. It is now read-only.

Check that histories directory exists before trying to create. #19

Merged
merged 1 commit into from
Nov 9, 2019

Conversation

glenpike
Copy link

@glenpike glenpike commented Nov 7, 2017

Add post-install script that should be cross-platform.
Closes #18

Add post-install script that should be cross-platform.
Closes alidavut#18
@alidavut
Copy link
Owner

alidavut commented Nov 7, 2017

Looks good to me. I think we can merge this and wait #17 for the other things.

And maybe you would like to use a module for cross-platform like https://github.com/substack/node-mkdirp

@glenpike
Copy link
Author

glenpike commented Nov 7, 2017

I was hoping it was cross-platform just using the built-in libs, but not easily able to test on Windows.

@alidavut
Copy link
Owner

alidavut commented Nov 7, 2017

I didn't remember if windows has 'mkdir' command, seems it has. Let's merge if ok for you?

@glenpike
Copy link
Author

glenpike commented Nov 7, 2017

Happy with that - I looked it up, but I wasn't able to test.

@HuangChaoWH
Copy link

Hi, I released a private package:
@huangchaowh/locus
it works on Windows.
It change the postinstall to "mkdir histories".

@glenpike
Copy link
Author

@HuangChaoWH I don't think that fixes the initial problem which is that the postinstall fails if the directory exists. I am guessing you made a new postinstall rather than testing the one in this PR, but I maybe wrong?

@glenpike
Copy link
Author

Is there any chance of getting this reviewed, merged and published?
Everytime I have to rebuild my node stack, it fails because this directory exists and that's not a quick process.

@alidavut alidavut merged commit 5db0dee into alidavut:master Nov 9, 2019
@glenpike glenpike deleted the b18-histories-mkdir branch November 18, 2019 22:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed at the locus@2.0.1 postinstall script 'mkdir ./histories'.
3 participants