Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a search function for applications #49

Merged
merged 2 commits into from
Sep 30, 2021
Merged

Added a search function for applications #49

merged 2 commits into from
Sep 30, 2021

Conversation

loicalbertin
Copy link
Member

  • Added a Filters attribute on SearchRequest
  • Added a new SearchApplications(ctx context.Context, searchRequest SearchRequest) ([]Application, int, error) function on ApplicationService interface
  • Reused SearchApplications in GetApplicationsID to reduce duplications

Fixes #48 see it for more details

loicalbertin and others added 2 commits September 30, 2021 10:58
@loicalbertin
Added a search function for applications
c214e8c
@loicalbertin
Generating mocks
ca859a4 
Signed-off-by: loicalbertin <loicalbertin@users.noreply.github.com>
@loicalbertin loicalbertin self-assigned this Sep 30, 2021
laurentganne
laurentganne approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@laurentganne laurentganne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@loicalbertin loicalbertin merged commit 622a8a7 into master Sep 30, 2021
@loicalbertin loicalbertin deleted the feature/GH-48_allow_to_search_for_applications branch September 30, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentganne laurentganne laurentganne approved these changes

Assignees

@loicalbertin loicalbertin

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to search for applications
2 participants
@loicalbertin @laurentganne