Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdlada on Windows #134

Closed

Conversation

Fabien-Chouteau
Copy link
Member

With these changes it is now possible to compile and run sdlada project on windows.
alr -n get --build ada_voxel_space_demo

Using: alire-project/alire#336, alire-project/alire#452 and alire-project/alire#456.

Fabien-Chouteau and others added 6 commits September 8, 2020 18:18
The other make file targets are not required.

Also define SDL_PLATFORM for all targets so we don't have to user a different post-fetch for each OS.
This means the users of the lib can define the build mode they want.
@mosteo
Copy link
Member

mosteo commented Sep 8, 2020

I don't know why I had this sitting here for so long, sorry. I've migrated it to the new index so now it's a matter of passing the build tests.

@mosteo mosteo changed the base branch from devel-0.3 to devel-0.4 September 8, 2020 16:31
@Fabien-Chouteau Fabien-Chouteau requested a review from a team as a code owner September 8, 2020 16:48
@mosteo
Copy link
Member

mosteo commented Sep 8, 2020

It seems that indeed sdlada does not build with CE2020. @Fabien-Chouteau , can you reproduce?

@Fabien-Chouteau
Copy link
Member Author

@mosteo yes I can. It is fixed but we need a new release of SDLAda: https://github.com/Lucretia/sdlada/commit/cfb255a751bfaf7e8cbdb5ba4808decb78476ecb

@mosteo mosteo mentioned this pull request Oct 5, 2020
@mosteo
Copy link
Member

mosteo commented Oct 5, 2020

I'm closing this one in favor of #167, please let me know over there about any pending issue with this crate.

@mosteo mosteo closed this Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants