Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overall text enhancement #892

Merged
merged 47 commits into from
Feb 13, 2024
Merged

Overall text enhancement #892

merged 47 commits into from
Feb 13, 2024

Conversation

shahin-io
Copy link

@shahin-io shahin-io commented Jan 24, 2024

Hello dear @alireza0

This is the resubmitted version of the previous pull request with significantly reduced commits. I've edited it based on your feedback, and I've also included some enhancements for the WARP Modal.

Preview

26D7CA41-8ECC-4947-AC73-101C0D44E99E
BF06D78-457A-41BF-929B-FE62E5020071

web/html/xui/client_bulk_modal.html Show resolved Hide resolved
web/html/xui/index.html Outdated Show resolved Hide resolved
web/translation/translate.en_US.toml Outdated Show resolved Hide resolved
@shahin-io
Copy link
Author

shahin-io commented Jan 25, 2024

Dear @alireza0

Can you advise on whether it's good practice to change Traffic to Flow or Total Flow to Total Traffic? Currently, there is a conflict between these terms in the panel. For languages other than English, we already have consistent translations. Additionally, I suggest using Expiration instead of Expiry Date. The general term Expiration covers both date and time for the date picker."

@alireza0
Copy link
Owner

Dear @alireza0

Can you advise on whether it's good practice to change Traffic to Flow or Total Flow to Total Traffic? Currently, there is a conflict between these terms in the panel. For languages other than English, we already have consistent translations. Additionally, I suggest using Expiration instead of Expiry Date. The general term Expiration covers both date and time for the date picker."

With only Flow the meaning of Traffic will be unknown and makes confustion. I prefer Traffic and Total Traffic.
And Expiration is better.

@shahin-io
Copy link
Author

shahin-io commented Jan 30, 2024

Dear @alireza0 Jaan.

All the changes are final, and you can perform the final review for merging.

@alireza0
Copy link
Owner

Thanks a lot. I will check it ASAP

@alireza0 alireza0 merged commit 294a3f4 into alireza0:main Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants