Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patching lhapdf5 to avoid format security compilation error. #109

Closed
wants to merge 1 commit into from

Conversation

mpuccio
Copy link
Contributor

@mpuccio mpuccio commented Sep 22, 2015

I am trying to compile on Fedora 22 and on Mint 17.1 the O2 software using alibuild.
On both the systems I got stuck due to a format security error in the compilation of lhapdf5.
This small patch solves this issue for me, but maybe you have cleaner solution.

-Werror=format-security is turned on by default in 13.04 and later releases of Ubuntu.
This is also true for the latest Fedora releases.
@ktf
Copy link
Member

ktf commented Sep 22, 2015

Thank you for your fix.

IMHO what we should do, though, is to create an alisw/lhapdf5 repository and patch it there directly, so that people can se the actual code being built. Unless you need this immediately, I'm going to do it tomorrow and integrate your patch there.

@dberzano

@dberzano
Copy link
Contributor

Yes @ktf I second that, proceed.

@mpuccio, thanks for spotting this!

@mpuccio
Copy link
Contributor Author

mpuccio commented Sep 22, 2015

Perfect! Thanks a lot, I close this pull request.

@mpuccio mpuccio closed this Sep 22, 2015
@ktf
Copy link
Member

ktf commented Sep 23, 2015

Actually I will be in a training the whole day so it might take me a while.
On Tue, 22 Sep 2015 at 23:29, Maximiliano Puccio notifications@github.com
wrote:

Perfect! Thanks a lot, I close this pull request.


Reply to this email directly or view it on GitHub
#109 (comment).

sawenzel pushed a commit to sawenzel/alidist that referenced this pull request Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants