Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump scikit-learn on older python versions #5524

Closed
wants to merge 1 commit into from

Conversation

singiamtel
Copy link
Collaborator

Fixes the following error (tested on python 3.10)

  Error compiling Cython file:
  ------------------------------------------------------------
  ...
      # Max value for our rand_r replacement (near the bottom).
      # We don't use RAND_MAX because it's different across platforms and
      # particularly tiny on Windows/MSVC.
      RAND_R_MAX = 0x7FFFFFFF

  cpdef sample_without_replacement(np.int_t n_population,
                                   ^
  ------------------------------------------------------------

  sklearn/utils/_random.pxd:18:33: 'int_t' is not a type identifier

Fixes the following error

```
  Error compiling Cython file:
  ------------------------------------------------------------
  ...
      # Max value for our rand_r replacement (near the bottom).
      # We don't use RAND_MAX because it's different across platforms and
      # particularly tiny on Windows/MSVC.
      RAND_R_MAX = 0x7FFFFFFF

  cpdef sample_without_replacement(np.int_t n_population,
                                   ^
  ------------------------------------------------------------

  sklearn/utils/_random.pxd:18:33: 'int_t' is not a type identifier
  ```
@singiamtel singiamtel requested a review from a team as a code owner July 1, 2024 09:47
@singiamtel singiamtel marked this pull request as draft July 9, 2024 12:44
@singiamtel
Copy link
Collaborator Author

Closing as #5547 supersedes

@singiamtel singiamtel closed this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant