refactor: solve the inconsistency of credentials refresh && add the m… #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yndu13
force-pushed
the
refresh-credential
branch
2 times, most recently
from
a52c457
to
c49b9f3
Compare
peze
approved these changes
Jun 12, 2023
yndu13
force-pushed
the
refresh-credential
branch
6 times, most recently
from
50b4c9a
to
db30f7d
Compare
JacksonTian
reviewed
Jun 12, 2023
| public String STSEndpoint; | ||
| public String STSEndpoint = "sts.aliyuncs.com"; | ||
| @NameInMap("asyncCredentialUpdateEnabled") | ||
| public boolean asyncCredentialUpdateEnabled = false; |
There was a problem hiding this comment.
嗯嗯，现在的设计是支持阻塞、非阻塞两种刷新，非阻塞的刷新其实是推荐的
JacksonTian
reviewed
Jun 12, 2023
| return new Builder(); | ||
| } | ||
|
|
||
| public Credential setAccessKeyId(String accessKeyId) { |
There was a problem hiding this comment.
有了 builder setXXX 是不是就不需要了。
There was a problem hiding this comment.
本应该不需要的，但是这个credential是Model，model的设计是setters进行配置，这个只能看看darabonba v2要不要去掉
JacksonTian
reviewed
Jun 12, 2023
| @@ -61,7 +61,7 @@ public void createCredentialTest() { | |||
| response.setHttpContent(new String("{\"SessionAccessKey\":{\"Expiration\":\"2019-12-12T1:1:1Z\",\"SessionAccessKeyId\":\"test\"," + | |||
| "\"SessionAccessKeySecret\":\"test\"}}").getBytes(), "UTF-8", FormatType.JSON); | |||
| when(client.syncInvoke(ArgumentMatchers.<HttpRequest>any())).thenReturn(response); | |||
| Assert.assertTrue(provider.createCredential(client) instanceof RsaKeyPairCredential); | |||
| Assert.assertEquals(AuthConstant.RSA_KEY_PAIR, provider.createCredential(client).value().getType()); | |||
JacksonTian
reviewed
Jun 12, 2023
| @@ -62,7 +62,8 @@ | |||
| <dependency> | |||
| <groupId>com.aliyun</groupId> | |||
| <artifactId>tea</artifactId> | |||
| <version>1.0.6</version> | |||
| <version>1.2.7</version> | |||
yndu13
force-pushed
the
refresh-credential
branch
2 times, most recently
from
91ef469
to
61a0773
Compare
JacksonTian
approved these changes
Jun 13, 2023
yndu13
force-pushed
the
refresh-credential
branch
5 times, most recently
from
9ce8075
to
fbbe5fa
Compare
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
============================================
- Coverage 87.88% 84.42% -3.46%
- Complexity 457 482 +25
============================================
Files 39 44 +5
Lines 1304 1740 +436
Branches 94 111 +17
============================================
+ Hits 1146 1469 +323
- Misses 136 234 +98
- Partials 22 37 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
yndu13
changed the title
yndu13
force-pushed
the
refresh-credential
branch
from
fbbe5fa
to
8e29ef5
Compare
yndu13
changed the title
yndu13
force-pushed
the
refresh-credential
branch
from
8e29ef5
to
a6481d9
Compare
…ethod of asynchronous refresh
yndu13
force-pushed
the
refresh-credential
branch
from
a6481d9
to
e9493f7
Compare
JacksonTian
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ethod of asynchronous refresh
You need to complete