Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support externalId for ram role arn #51

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

yndu13
Copy link
Collaborator

@yndu13 yndu13 commented Jun 26, 2023

You need to complete
  • unit tests and/or feature tests
  • documentation is changed or added

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2023

Codecov Report

Merging #51 (be6e710) into master (844da20) will increase coverage by 0.90%.
The diff coverage is 83.33%.

❗ Current head be6e710 differs from pull request most recent head 41440e8. Consider uploading reports for the commit 41440e8 to get more accurate results

@@             Coverage Diff              @@
##             master      #51      +/-   ##
============================================
+ Coverage     84.42%   85.33%   +0.90%     
- Complexity      482      501      +19     
============================================
  Files            44       44              
  Lines          1740     1752      +12     
  Branches        111      112       +1     
============================================
+ Hits           1469     1495      +26     
+ Misses          234      221      -13     
+ Partials         37       36       -1     
Flag Coverage Δ
unittest 85.33% <83.33%> (+0.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain/java/com/aliyun/credentials/models/Config.java 42.85% <33.33%> (+25.87%) ⬆️
src/main/java/com/aliyun/credentials/Client.java 70.23% <100.00%> (+0.35%) ⬆️
...entials/provider/RamRoleArnCredentialProvider.java 98.12% <100.00%> (+1.41%) ⬆️

@yndu13 yndu13 merged commit ec7d32f into master Jun 26, 2023
@yndu13 yndu13 deleted the support-externalid branch June 26, 2023 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants