fix: putStream can not close request when stream destroyed (#782)

Author: weiyie

lib/object.js

@@ -10,6 +10,7 @@ const mime = require('mime');
 const callback = require('./common/callback');
 const signHelper = require('./common/signUtils');
 const { Transform } = require('stream');
+const pump = require('pump');
 
 const proto = exports;
 
@@ -129,7 +130,7 @@ proto.putStream = async function putStream(name, stream, options) {
     this.push(chunk);
     done();
   };
-  params.stream = stream.pipe(transform);
+  params.stream = pump(stream, transform);
   params.successStatuses = [200];
 
   const result = await this.request(params);

package.json

@@ -128,6 +128,7 @@
     "mime": "^2.4.5",
     "mz-modules": "^2.1.0",
     "platform": "^1.3.1",
+    "pump": "^3.0.0",
     "sdk-base": "^2.0.1",
     "stream-http": "2.8.2",
     "stream-wormhole": "^1.0.4",

test/node/object.test.js

@@ -159,6 +159,20 @@ describe('test/object.test.js', () => {
       assert.equal(r.content.length, buf.length);
       assert.deepEqual(r.content, buf);
     });
+
+    it('should throw error with stream destroy', async () => {
+      const name = `${prefix}ali-sdk/oss/putStream-source-destroy.js`;
+      try {
+        const readerStream = fs.createReadStream(__filename);
+
+        readerStream.on('data', () => {
+          readerStream.destroy();
+        });
+        await store.putStream(name, readerStream);
+      } catch (error) {
+        assert.strictEqual(error.status, -1);
+      }
+    });
   });
 
   describe('processObjectSave()', () => {