Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set default value as 7 for contributorsPerLine #139

Merged
merged 11 commits into from
Sep 7, 2022

Conversation

jakebolam
Copy link
Collaborator

No description provided.

@Berkmann18 Berkmann18 added this to In progress in All Contributors Kanban Jan 29, 2019
All Contributors Kanban automation moved this from In progress to Review Apr 15, 2019
@Berkmann18
Copy link
Member

Is it still a WIP?

@Berkmann18
Copy link
Member

@jakebolam What's left to do for this?

@tenshiAMD
Copy link
Member

@jakebolam What's left to do for this?

@Berkmann18 I think we can merge this one since basically @jakebolam set a default fallback value for contributorsPerLine with the value of 7 thus it does not need a setting in the config file.

@tenshiAMD tenshiAMD changed the title WIP fix: ensure node api can be used without configuration object based in fix: set default value as 7 for contributorsPerLine Sep 6, 2022
@tenshiAMD tenshiAMD enabled auto-merge (squash) September 7, 2022 08:26
@tenshiAMD tenshiAMD merged commit e1fd794 into master Sep 7, 2022
All Contributors Kanban automation moved this from Review to Done Sep 7, 2022
@tenshiAMD tenshiAMD deleted the fix/node-api-fixes branch September 7, 2022 08:27
@all-contributors-release-bot
Copy link
Member

🎉 This PR is included in version 6.20.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

tenshiAMD added a commit that referenced this pull request Sep 13, 2022
* origin/master: (85 commits)
  refactor: log full error stack on error (#316)
  chore: fix status badges (#315)
  docs: add JoshuaKGoldberg as a contributor for bug (#314)
  fix: incorrect usage of `tbody` (#311)
  fix: trim `nextLink` before slicing (#309)
  fix: set default value as `7` for `contributorsPerLine` (#139)
  chore(deps): bump dependencies and devDeps (#298)
  refactor: add tbody to contributors table (#307)
  docs: add Lucas-C as a contributor for doc (#306)
  fix: scriptName + improving usage messages (#305)
  docs: add vapurrmaid as a contributor (#304)
  chore(deps): CVE-2021-23337 in inquirer->lodash (#303)
  docs: add SirWindfield as a contributor (#297)
  feat: add namespaced token (#296)
  docs: add LaChapeliere as a contributor (#292)
  feat(contribution-types): add research contribution type (#291)
  docs: add darekkay as a contributor (#290)
  feat: display a meaningful error when the config file is missing (#288)
  docs: add melink14 as a contributor (#285)
  docs: add jdalrymple as a contributor (#264)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants