Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: log full error stack on error #316

Merged
merged 1 commit into from
Sep 10, 2022
Merged

refactor: log full error stack on error #316

merged 1 commit into from
Sep 10, 2022

Conversation

JoshuaKGoldberg
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg commented Sep 9, 2022

What:

Why:

  • It's harder to debug failures without it.

How:

  • Update implementation for onError.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

Thank you @tenshiAMD ❤️ #313

@tenshiAMD tenshiAMD changed the title feat: log full error stack on error refactor: log full error stack on error Sep 10, 2022
@tenshiAMD tenshiAMD merged commit 097f741 into all-contributors:master Sep 10, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the log-more-error branch September 10, 2022 11:12
tenshiAMD added a commit that referenced this pull request Sep 13, 2022
* origin/master: (85 commits)
  refactor: log full error stack on error (#316)
  chore: fix status badges (#315)
  docs: add JoshuaKGoldberg as a contributor for bug (#314)
  fix: incorrect usage of `tbody` (#311)
  fix: trim `nextLink` before slicing (#309)
  fix: set default value as `7` for `contributorsPerLine` (#139)
  chore(deps): bump dependencies and devDeps (#298)
  refactor: add tbody to contributors table (#307)
  docs: add Lucas-C as a contributor for doc (#306)
  fix: scriptName + improving usage messages (#305)
  docs: add vapurrmaid as a contributor (#304)
  chore(deps): CVE-2021-23337 in inquirer->lodash (#303)
  docs: add SirWindfield as a contributor (#297)
  feat: add namespaced token (#296)
  docs: add LaChapeliere as a contributor (#292)
  feat(contribution-types): add research contribution type (#291)
  docs: add darekkay as a contributor (#290)
  feat: display a meaningful error when the config file is missing (#288)
  docs: add melink14 as a contributor (#285)
  docs: add jdalrymple as a contributor (#264)
  ...
@all-contributors-release-bot
Copy link
Member

🎉 This PR is included in version 6.20.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full stack should be logged in CLI onError
3 participants