Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contribution-types): add research contribution type #291

Merged
merged 3 commits into from
Oct 9, 2020

Conversation

LaChapeliere
Copy link
Contributor

@LaChapeliere LaChapeliere commented Oct 8, 2020

What:
Add a research contribution type with microscope emoji, for people doing literature review, code
prototyping or any other research-related activity.

Part 2/3 of #446

Why:
For open science projects or dev projects with a research component, people carrying out research tasks cannot always be acknowledged with the existing types.

Adding the type description and emoji to the list of types available to the CLI tool.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

I'm not really familiar with npm so I'm not sure how to install my modified version of the cli tool to test it. Any help?
Bot PR following.

Add a research contribution type with microscope emoji, for people doing literature review, code
prototyping or any other research-related activity.

#446
Fix name of added type (was "question" due to copy pasting) and position (alphabetical order)

#446
src/util/contribution-types.js Outdated Show resolved Hide resolved
@Berkmann18 Berkmann18 added this to In progress in All Contributors Kanban via automation Oct 8, 2020
@Berkmann18 Berkmann18 changed the title feat(contribution-types.js): add research contribution type feat(contribution-types): add research contribution type Oct 8, 2020
Co-authored-by: Maximilian Berkmann <maxieberkmann@gmail.com>
All Contributors Kanban automation moved this from In progress to Review Oct 9, 2020
@Berkmann18 Berkmann18 merged commit f9f2866 into all-contributors:master Oct 9, 2020
All Contributors Kanban automation moved this from Review to Done Oct 9, 2020
@Berkmann18
Copy link
Member

@all-contributors Please add @LaChapeliere for code

@allcontributors
Copy link
Contributor

@Berkmann18

I've put up a pull request to add @LaChapeliere! 🎉

@all-contributors-release-bot
Copy link
Member

🎉 This PR is included in version 6.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

@Guardian88 Guardian88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blackguard88

@all-contributors all-contributors deleted a comment from Guardian88 Nov 21, 2020
@all-contributors all-contributors deleted a comment from Guardian88 Nov 21, 2020
tenshiAMD added a commit that referenced this pull request Sep 13, 2022
* origin/master: (85 commits)
  refactor: log full error stack on error (#316)
  chore: fix status badges (#315)
  docs: add JoshuaKGoldberg as a contributor for bug (#314)
  fix: incorrect usage of `tbody` (#311)
  fix: trim `nextLink` before slicing (#309)
  fix: set default value as `7` for `contributorsPerLine` (#139)
  chore(deps): bump dependencies and devDeps (#298)
  refactor: add tbody to contributors table (#307)
  docs: add Lucas-C as a contributor for doc (#306)
  fix: scriptName + improving usage messages (#305)
  docs: add vapurrmaid as a contributor (#304)
  chore(deps): CVE-2021-23337 in inquirer->lodash (#303)
  docs: add SirWindfield as a contributor (#297)
  feat: add namespaced token (#296)
  docs: add LaChapeliere as a contributor (#292)
  feat(contribution-types): add research contribution type (#291)
  docs: add darekkay as a contributor (#290)
  feat: display a meaningful error when the config file is missing (#288)
  docs: add melink14 as a contributor (#285)
  docs: add jdalrymple as a contributor (#264)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants