refactor: add tbody to contributors table #307

hpierre74 · 2022-01-07T11:40:21Z

What: The contributors table generator

Why: Browsers are inserting tbody inside tables when it is not found, it is not really enforced by W3C to add tbody but since MDX will complain because of the react usage beneath it, I think this change has no negative impact and can fix an error in some docusaurus (or other MDX solutions).
FYI: When react reconciles the tree it finds a difference in the markup since browsers add the tbody, leading to an error

How: Simply wrap the tr inside a tbody in the generator html string

Checklist:

Documentation
Tests
Ready to be merged
Added myself to contributors table

Berkmann18 · 2022-01-07T18:48:38Z

Where do you even get that error?

Also, it might be worth fixing your PR so the failing CI check passes.

hpierre74 · 2022-01-08T12:25:29Z

Where do you even get that error?

Using MDX instead of markdown.
I have a Docusaurus site where I copy pasted the contributors table leading to a react error.
I easily fixed it by hand but I thought this would be a harmless contribution

Also, it might be worth fixing your PR so the failing CI check passes.

Precisely why I'm using WIP in the title... I'll finish this ASAP

hpierre74 · 2022-01-08T14:01:21Z

I'm failing to understand whats wrong with the CI check though

error chalk@5.0.0: The engine "node" is incompatible with this module. Expected version "^12.17.0 || ^14.13 || >=16.0.0". Got "12.14.0"

While package.json states:

  "chalk": "^4.0.0",

And yarn why says:

=> Found "chalk@4.1.2"
info Has been hoisted to "chalk"
info Reasons this module exists
   - Specified in "dependencies"
   - Hoisted from "@jest#console#chalk"
   - Hoisted from "@jest#types#chalk"
   - Hoisted from "jest-message-util#chalk"
   - Hoisted from "jest-util#chalk"
   - Hoisted from "inquirer#chalk"
   - Hoisted from "kcd-scripts#chalk"
   - Hoisted from "json-fixer#chalk"
   - Hoisted from "cz-conventional-changelog#@commitlint#load#chalk"
   - Hoisted from "kcd-scripts#babel-jest#chalk"
   - Hoisted from "kcd-scripts#eslint#chalk"
   - Hoisted from "kcd-scripts#husky#chalk"
   - Hoisted from "kcd-scripts#jest-watch-typeahead#chalk"
   - Hoisted from "kcd-scripts#rollup-plugin-size-snapshot#chalk"
   - Hoisted from "kcd-scripts#lint-staged#chalk"
   - Hoisted from "semantic-release#marked-terminal#chalk"
   - Hoisted from "cz-conventional-changelog#@commitlint#load#@commitlint#types#chalk"
   - Hoisted from "kcd-scripts#jest#@jest#core#chalk"
   - Hoisted from "kcd-scripts#babel-jest#@jest#transform#chalk"
   - Hoisted from "kcd-scripts#jest#jest-cli#chalk"
   - Hoisted from "kcd-scripts#@types#jest#jest-diff#chalk"
   - Hoisted from "kcd-scripts#jest-watch-typeahead#jest-watcher#chalk"
   - Hoisted from "kcd-scripts#lint-staged#log-symbols#chalk"
   - Hoisted from "semantic-release#@semantic-release#npm#npm#chalk"
   - Hoisted from "kcd-scripts#jest#@jest#core#@jest#reporters#chalk"
   - Hoisted from "kcd-scripts#jest-watch-typeahead#jest-watcher#@jest#types#chalk"
   - Hoisted from "kcd-scripts#jest#@jest#core#jest-config#chalk"
   - Hoisted from "kcd-scripts#jest#@jest#core#jest-resolve#chalk"
   - Hoisted from "kcd-scripts#jest#@jest#core#jest-runner#chalk"
   - Hoisted from "kcd-scripts#jest#@jest#core#jest-runtime#chalk"
   - Hoisted from "kcd-scripts#jest#@jest#core#jest-snapshot#chalk"
   - Hoisted from "kcd-scripts#jest-watch-typeahead#jest-watcher#jest-util#chalk"
   - Hoisted from "kcd-scripts#jest#@jest#core#jest-validate#chalk"
   - Hoisted from "kcd-scripts#jest#@jest#core#jest-watcher#chalk"
   - Hoisted from "semantic-release#@semantic-release#npm#npm#npm-audit-report#chalk"
   - Hoisted from "kcd-scripts#eslint-config-kentcdodds#eslint-plugin-jest-dom#@testing-library#dom#chalk"
   - Hoisted from "semantic-release#@semantic-release#npm#npm#libnpmexec#chalk"
   - Hoisted from "kcd-scripts#jest-watch-typeahead#jest-watcher#@jest#test-result#@jest#console#chalk"
   - Hoisted from "kcd-scripts#jest#@jest#core#jest-config#jest-jasmine2#chalk"
   - Hoisted from "kcd-scripts#jest#@jest#core#jest-snapshot#jest-matcher-utils#chalk"
   - Hoisted from "kcd-scripts#jest#@jest#core#jest-config#jest-jasmine2#jest-each#chalk"
   - Hoisted from "kcd-scripts#jest-watch-typeahead#jest-watcher#@jest#test-result#@jest#console#jest-message-util#chalk"
info Disk size without dependencies: "56KB"
info Disk size with unique dependencies: "108KB"
info Disk size with transitive dependencies: "192KB"
info Number of shared dependencies: 5
=> Found "cz-conventional-changelog#chalk@2.4.2"
info This module exists because "cz-conventional-changelog" depends on it.
info Disk size without dependencies: "44KB"
info Disk size with unique dependencies: "112KB"
info Disk size with transitive dependencies: "196KB"
info Number of shared dependencies: 6
=> Found "@babel/highlight#chalk@2.4.2"
info This module exists because "@babel#code-frame#@babel#highlight" depends on it.
info Disk size without dependencies: "44KB"
info Disk size with unique dependencies: "112KB"
info Disk size with transitive dependencies: "196KB"
info Number of shared dependencies: 6
=> Found "signale#chalk@2.4.2"
info This module exists because "semantic-release#signale" depends on it.
info Disk size without dependencies: "44KB"
info Disk size with unique dependencies: "112KB"
info Disk size with transitive dependencies: "196KB"
info Number of shared dependencies: 6
=> Found "concurrently#chalk@2.4.2"
info This module exists because "kcd-scripts#concurrently" depends on it.
info Disk size without dependencies: "72KB"
info Disk size with unique dependencies: "140KB"
info Disk size with transitive dependencies: "224KB"
info Number of shared dependencies: 6
=> Found "commitizen#chalk@2.4.2"
info Reasons this module exists
   - "cz-conventional-changelog#commitizen#cz-conventional-changelog" depends on it
   - Hoisted from "cz-conventional-changelog#commitizen#cz-conventional-changelog#chalk"
   - Hoisted from "cz-conventional-changelog#commitizen#inquirer#chalk"
info Disk size without dependencies: "44KB"
info Disk size with unique dependencies: "112KB"
info Disk size with transitive dependencies: "196KB"
info Number of shared dependencies: 6

tlylt · 2022-05-03T08:04:47Z

Hi, may I check if there are any updates on this PR?

I faced a similar issue lately, the use case is as such:

I will use the all-contributors cli to modify both my README.md and a separate about.md file, which I render using a combination of custom markdown parser (markdown-it) and Vue to generate the final html. Due to the missing <tbody>, it causes a hydration issue from Vue:

[Vue warn]: The client-side rendered virtual DOM tree is not matching server-rendered content. This is likely caused by incorrect HTML markup, for example nesting block-level elements inside <p>, or missing <tbody>. Bailing hydration and performing full client-side render.

Berkmann18 · 2022-08-16T10:12:05Z

I'm failing to understand whats wrong with the CI check though

error chalk@5.0.0: The engine "node" is incompatible with this module. Expected version "^12.17.0 || ^14.13 || >=16.0.0". Got "12.14.0"

While package.json states:

  "chalk": "^4.0.0",

And yarn why says:

=> Found "chalk@4.1.2"
info Has been hoisted to "chalk"
info Reasons this module exists
   - Specified in "dependencies"
   - Hoisted from "@jest#console#chalk"
   - Hoisted from "@jest#types#chalk"
   - Hoisted from "jest-message-util#chalk"
   - Hoisted from "jest-util#chalk"
   - Hoisted from "inquirer#chalk"
   - Hoisted from "kcd-scripts#chalk"
   - Hoisted from "json-fixer#chalk"
   - Hoisted from "cz-conventional-changelog#@commitlint#load#chalk"
   - Hoisted from "kcd-scripts#babel-jest#chalk"
   - Hoisted from "kcd-scripts#eslint#chalk"
   - Hoisted from "kcd-scripts#husky#chalk"
   - Hoisted from "kcd-scripts#jest-watch-typeahead#chalk"
   - Hoisted from "kcd-scripts#rollup-plugin-size-snapshot#chalk"
   - Hoisted from "kcd-scripts#lint-staged#chalk"
   - Hoisted from "semantic-release#marked-terminal#chalk"
   - Hoisted from "cz-conventional-changelog#@commitlint#load#@commitlint#types#chalk"
   - Hoisted from "kcd-scripts#jest#@jest#core#chalk"
   - Hoisted from "kcd-scripts#babel-jest#@jest#transform#chalk"
   - Hoisted from "kcd-scripts#jest#jest-cli#chalk"
   - Hoisted from "kcd-scripts#@types#jest#jest-diff#chalk"
   - Hoisted from "kcd-scripts#jest-watch-typeahead#jest-watcher#chalk"
   - Hoisted from "kcd-scripts#lint-staged#log-symbols#chalk"
   - Hoisted from "semantic-release#@semantic-release#npm#npm#chalk"
   - Hoisted from "kcd-scripts#jest#@jest#core#@jest#reporters#chalk"
   - Hoisted from "kcd-scripts#jest-watch-typeahead#jest-watcher#@jest#types#chalk"
   - Hoisted from "kcd-scripts#jest#@jest#core#jest-config#chalk"
   - Hoisted from "kcd-scripts#jest#@jest#core#jest-resolve#chalk"
   - Hoisted from "kcd-scripts#jest#@jest#core#jest-runner#chalk"
   - Hoisted from "kcd-scripts#jest#@jest#core#jest-runtime#chalk"
   - Hoisted from "kcd-scripts#jest#@jest#core#jest-snapshot#chalk"
   - Hoisted from "kcd-scripts#jest-watch-typeahead#jest-watcher#jest-util#chalk"
   - Hoisted from "kcd-scripts#jest#@jest#core#jest-validate#chalk"
   - Hoisted from "kcd-scripts#jest#@jest#core#jest-watcher#chalk"
   - Hoisted from "semantic-release#@semantic-release#npm#npm#npm-audit-report#chalk"
   - Hoisted from "kcd-scripts#eslint-config-kentcdodds#eslint-plugin-jest-dom#@testing-library#dom#chalk"
   - Hoisted from "semantic-release#@semantic-release#npm#npm#libnpmexec#chalk"
   - Hoisted from "kcd-scripts#jest-watch-typeahead#jest-watcher#@jest#test-result#@jest#console#chalk"
   - Hoisted from "kcd-scripts#jest#@jest#core#jest-config#jest-jasmine2#chalk"
   - Hoisted from "kcd-scripts#jest#@jest#core#jest-snapshot#jest-matcher-utils#chalk"
   - Hoisted from "kcd-scripts#jest#@jest#core#jest-config#jest-jasmine2#jest-each#chalk"
   - Hoisted from "kcd-scripts#jest-watch-typeahead#jest-watcher#@jest#test-result#@jest#console#jest-message-util#chalk"
info Disk size without dependencies: "56KB"
info Disk size with unique dependencies: "108KB"
info Disk size with transitive dependencies: "192KB"
info Number of shared dependencies: 5
=> Found "cz-conventional-changelog#chalk@2.4.2"
info This module exists because "cz-conventional-changelog" depends on it.
info Disk size without dependencies: "44KB"
info Disk size with unique dependencies: "112KB"
info Disk size with transitive dependencies: "196KB"
info Number of shared dependencies: 6
=> Found "@babel/highlight#chalk@2.4.2"
info This module exists because "@babel#code-frame#@babel#highlight" depends on it.
info Disk size without dependencies: "44KB"
info Disk size with unique dependencies: "112KB"
info Disk size with transitive dependencies: "196KB"
info Number of shared dependencies: 6
=> Found "signale#chalk@2.4.2"
info This module exists because "semantic-release#signale" depends on it.
info Disk size without dependencies: "44KB"
info Disk size with unique dependencies: "112KB"
info Disk size with transitive dependencies: "196KB"
info Number of shared dependencies: 6
=> Found "concurrently#chalk@2.4.2"
info This module exists because "kcd-scripts#concurrently" depends on it.
info Disk size without dependencies: "72KB"
info Disk size with unique dependencies: "140KB"
info Disk size with transitive dependencies: "224KB"
info Number of shared dependencies: 6
=> Found "commitizen#chalk@2.4.2"
info Reasons this module exists
   - "cz-conventional-changelog#commitizen#cz-conventional-changelog" depends on it
   - Hoisted from "cz-conventional-changelog#commitizen#cz-conventional-changelog#chalk"
   - Hoisted from "cz-conventional-changelog#commitizen#inquirer#chalk"
info Disk size without dependencies: "44KB"
info Disk size with unique dependencies: "112KB"
info Disk size with transitive dependencies: "196KB"
info Number of shared dependencies: 6

It states that it needs chalk to be v12.17 or above (no idea why).

tlylt · 2022-08-16T13:45:03Z

I'm failing to understand whats wrong with the CI check though

error chalk@5.0.0: The engine "node" is incompatible with this module. Expected version "^12.17.0 || ^14.13 || >=16.0.0". Got "12.14.0"

It states that it needs chalk to be v12.17 or above (no idea why).

I think the v12.17 is referring to the node version, it needs to be 12.17 and above for chalk v5

Berkmann18 · 2022-09-06T20:40:03Z

I'm failing to understand whats wrong with the CI check though

error chalk@5.0.0: The engine "node" is incompatible with this module. Expected version "^12.17.0 || ^14.13 || >=16.0.0". Got "12.14.0"

It states that it needs chalk to be v12.17 or above (no idea why).

I think the v12.17 is referring to the node version, it needs to be 12.17 and above for chalk v5

That's true; I misread that.

tenshiAMD

@hpierre74 Hi, awesome man! validate_and_deploy is now working again. Please check the requested changes. Thanks! 🎉

tenshiAMD · 2022-09-06T22:56:35Z

src/generate/index.js

    newContent => {
-      return `\n<table>\n  <tr>\n    ${newContent}\n  </tr>\n</table>\n\n`
+      return `\n<table>\n  \n<tbody>\n    <tr>\n      ${newContent}\n      </tr>\n    </tobdy>\n  </table>\n\n`


@hpierre74 looks like need to write a test for this one

tenshiAMD · 2022-09-06T22:57:06Z

src/generate/index.js

@@ -55,9 +55,9 @@ function generateContributorsList(options, contributors) {
    }),
    _.chunk(options.contributorsPerLine),
    _.map(formatLine),
-    _.join('\n  </tr>\n  <tr>\n    '),
+    _.join('\n      </tr>\n      <tr>\n    '),


@hpierre74 also need test for this one

tenshiAMD · 2022-09-06T23:10:18Z

Somehow related to #163

hpierre74 · 2022-09-06T23:12:20Z

@tenshiAMD I'm trying to figure this out as we speak, adding spaces there and there 😄

hpierre74 · 2022-09-06T23:55:19Z

Now there is an unrelated test failing, I suspect this is a side effect of upgrading circleci node version, I'll look into it

[test] FAIL src/util/__tests__/url.js (10.5 s)
[test]   ● Throw an error when parsed input isn't a URL
[test] 
[test]     expect(received).toThrowError(expected)
[test] 
[test]     Expected substring: "Invalid URL: http://some string"
[test]     Received message:   "Invalid URL"
[test] 
[test]           18 |   }
[test]           19 |
[test]         > 20 |   const url = new URL(new RegExp('^\\w+\\:\\/\\/').test(input) ? input : `http://${input}`)
[test]              |               ^
[test]           21 |
[test]           22 |   if (!isHttpProtocol(url.protocol)) {
[test]           23 |     throw new TypeError('Provided URL has an invalid protocol')
[test] 
[test]       at parseHttpUrl (src/util/url.js:20:15)
[test]       at Object.<anonymous> (node_modules/expect/build/toThrowMatchers.js:83:11)
[test]       at Object.toThrowError (node_modules/expect/build/index.js:338:21)
[test]       at Object.<anonymous> (src/util/__tests__/url.js:48:48)
[test]       at Object.<anonymous> (src/util/__tests__/url.js:48:48)

tenshiAMD

@hpierre74 LGTM however I noticed some changes. Why are some unnecessary lines got changed? Are you using a custom .editorconfig plugin or something?

tenshiAMD

@hpierre74 LGTM however I noticed some changes. Why are some unnecessary lines got changed? Are you using a custom .editorconfig plugin or something? I think we can remove those first then we can merge this one. Cheers! 🎉

src/util/__tests__/url.js

src/generate/index.js

src/util/__tests__/url.js

tlylt · 2022-09-07T00:55:54Z

Now there is an unrelated test failing, I suspect this is a side effect of upgrading circleci node version, I'll look into it

[test] FAIL src/util/__tests__/url.js (10.5 s)
[test]   ● Throw an error when parsed input isn't a URL
[test] 
[test]     expect(received).toThrowError(expected)
[test] 
[test]     Expected substring: "Invalid URL: http://some string"
[test]     Received message:   "Invalid URL"
[test] 
[test]           18 |   }
[test]           19 |
[test]         > 20 |   const url = new URL(new RegExp('^\\w+\\:\\/\\/').test(input) ? input : `http://${input}`)
[test]              |               ^
[test]           21 |
[test]           22 |   if (!isHttpProtocol(url.protocol)) {
[test]           23 |     throw new TypeError('Provided URL has an invalid protocol')
[test] 
[test]       at parseHttpUrl (src/util/url.js:20:15)
[test]       at Object.<anonymous> (node_modules/expect/build/toThrowMatchers.js:83:11)
[test]       at Object.toThrowError (node_modules/expect/build/index.js:338:21)
[test]       at Object.<anonymous> (src/util/__tests__/url.js:48:48)
[test]       at Object.<anonymous> (src/util/__tests__/url.js:48:48)

FYI the failure is due to the change in behavior for new URL() from node 12 to node 16 and above.
E.g Node 12 ("Invalid URL: Hello world")

Node 17 ("Invalid URL")

src/util/__tests__/url.js

all-contributors-release-bot · 2022-09-07T08:22:42Z

🎉 This PR is included in version 6.20.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

tlylt · 2022-09-07T08:24:34Z

Hi @tenshiAMD, wonder if you know whether this change will propagate to the all-contributor bot immediately or will need to wait for the https://github.com/all-contributors/app side to update?

tenshiAMD · 2022-09-07T09:31:40Z

Hi @tenshiAMD, wonder if you know whether this change will propagate to the all-contributor bot immediately or will need to wait for the https://github.com/all-contributors/app side to update?

@tlylt not totally sure about this but I guess there is a slight delay thus it is always best to wait for few minutes or so.

tlylt · 2022-09-07T11:36:56Z

Hi @tenshiAMD, wonder if you know whether this change will propagate to the all-contributor bot immediately or will need to wait for the all-contributors/app side to update?

@tlylt not totally sure about this but I guess there is a slight delay thus it is always best to wait for few minutes or so.

Thanks @tenshiAMD !

Just tried it after a few hours and it doesn't seem to be updated:

Perhaps the app side needs to update the cli dependency to the latest for this to work... Thanks anyway

tenshiAMD · 2022-09-07T13:25:00Z

Perhaps the app side needs to update the cli dependency to the latest for this to work... Thanks anyway

@tlylt referring you to @Berkmann18. He might help us regarding this issue.

tenshiAMD · 2022-09-07T17:23:45Z

@tlylt I made a PR for this, we are just waiting for @Berkmann18 or @gr2m to merge it. Thanks! 🎉

tenshiAMD · 2022-09-07T20:25:21Z

@tlylt can you check again now? Please let us know. Thanks! 🎉

tlylt · 2022-09-08T01:02:44Z

@tlylt can you check again now? Please let us know. Thanks! 🎉

Tested and works well! Thank you for the follow-up 💯

* origin/master: (85 commits) refactor: log full error stack on error (#316) chore: fix status badges (#315) docs: add JoshuaKGoldberg as a contributor for bug (#314) fix: incorrect usage of `tbody` (#311) fix: trim `nextLink` before slicing (#309) fix: set default value as `7` for `contributorsPerLine` (#139) chore(deps): bump dependencies and devDeps (#298) refactor: add tbody to contributors table (#307) docs: add Lucas-C as a contributor for doc (#306) fix: scriptName + improving usage messages (#305) docs: add vapurrmaid as a contributor (#304) chore(deps): CVE-2021-23337 in inquirer->lodash (#303) docs: add SirWindfield as a contributor (#297) feat: add namespaced token (#296) docs: add LaChapeliere as a contributor (#292) feat(contribution-types): add research contribution type (#291) docs: add darekkay as a contributor (#290) feat: display a meaningful error when the config file is missing (#288) docs: add melink14 as a contributor (#285) docs: add jdalrymple as a contributor (#264) ...

The huge diff is caused by all-contributors/cli#307

hpierre74 changed the title ~~refactor: add tbody to contributors table~~ refactor: add tbody to contributors table (WIP) Jan 7, 2022

hpierre74 force-pushed the tbody-addition branch from 2c7f387 to 2f9440c Compare January 8, 2022 12:35

refactor: add tbody to contributors table

d65f793

hpierre74 force-pushed the tbody-addition branch from 2f9440c to d65f793 Compare January 8, 2022 12:37

hpierre74 changed the title ~~refactor: add tbody to contributors table (WIP)~~ refactor: add tbody to contributors table Jan 8, 2022

tlylt mentioned this pull request May 3, 2022

Update about us with all-contributors info MarkBind/markbind#1919

Merged

9 tasks

hpierre74 force-pushed the tbody-addition branch 2 times, most recently from 6328d33 to 19bb6b0 Compare September 6, 2022 22:27

chore(node): bump version to lts

164e95d

hpierre74 force-pushed the tbody-addition branch from 19bb6b0 to 164e95d Compare September 6, 2022 22:29

tenshiAMD requested changes Sep 6, 2022

View reviewed changes

fix(html): add correct indentation

d0c9e26

hpierre74 requested a review from tenshiAMD September 6, 2022 23:48

test(url): fix bind error message

b976d4a

tenshiAMD requested changes Sep 7, 2022

View reviewed changes

tenshiAMD reviewed Sep 7, 2022

View reviewed changes

src/util/__tests__/url.js Show resolved Hide resolved

tenshiAMD approved these changes Sep 7, 2022

View reviewed changes

tenshiAMD merged commit deb6be9 into all-contributors:master Sep 7, 2022

all-contributors-release-bot added the released label Sep 7, 2022

This was referenced Sep 7, 2022

chore(package): bump all-contributors-cli all-contributors/app#401

Closed

fix(package): bump all-contributors-cli all-contributors/app#403

Merged

tlylt mentioned this pull request Sep 8, 2022

Update contributors table and remove unnecessary margin top MarkBind/markbind#2031

Merged

11 tasks

mtbc mentioned this pull request Sep 8, 2022

fix: incorrect usage of tbody #311

Merged

4 tasks

qyurila added a commit to qyurila/prettier-eslint that referenced this pull request Oct 9, 2022

chore: 👥 Update contributors

63e22e8

The huge diff is caused by all-contributors/cli#307

qyurila mentioned this pull request Oct 10, 2022

fix: Separate ESLint API options from option.eslintConfig prettier/prettier-eslint#798

Closed

qyurila added a commit to qyurila/prettier-eslint that referenced this pull request Oct 11, 2022

chore: 👥 Update contributors

546b1e2

The huge diff is caused by all-contributors/cli#307

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: add tbody to contributors table #307

refactor: add tbody to contributors table #307

hpierre74 commented Jan 7, 2022

Berkmann18 commented Jan 7, 2022

hpierre74 commented Jan 8, 2022 •

edited

hpierre74 commented Jan 8, 2022 •

edited

tlylt commented May 3, 2022

Berkmann18 commented Aug 16, 2022

tlylt commented Aug 16, 2022 •

edited

Berkmann18 commented Sep 6, 2022

tenshiAMD left a comment

tenshiAMD Sep 6, 2022

tenshiAMD Sep 6, 2022

tenshiAMD commented Sep 6, 2022

hpierre74 commented Sep 6, 2022

hpierre74 commented Sep 6, 2022

tenshiAMD left a comment •

edited

tenshiAMD left a comment

tlylt commented Sep 7, 2022

all-contributors-release-bot commented Sep 7, 2022

tlylt commented Sep 7, 2022

tenshiAMD commented Sep 7, 2022 •

edited

tlylt commented Sep 7, 2022

tenshiAMD commented Sep 7, 2022

tenshiAMD commented Sep 7, 2022

tenshiAMD commented Sep 7, 2022

tlylt commented Sep 8, 2022

refactor: add tbody to contributors table #307

refactor: add tbody to contributors table #307

Conversation

hpierre74 commented Jan 7, 2022

Berkmann18 commented Jan 7, 2022

hpierre74 commented Jan 8, 2022 • edited

hpierre74 commented Jan 8, 2022 • edited

tlylt commented May 3, 2022

Berkmann18 commented Aug 16, 2022

tlylt commented Aug 16, 2022 • edited

Berkmann18 commented Sep 6, 2022

tenshiAMD left a comment

Choose a reason for hiding this comment

tenshiAMD Sep 6, 2022

Choose a reason for hiding this comment

tenshiAMD Sep 6, 2022

Choose a reason for hiding this comment

tenshiAMD commented Sep 6, 2022

hpierre74 commented Sep 6, 2022

hpierre74 commented Sep 6, 2022

tenshiAMD left a comment • edited

Choose a reason for hiding this comment

tenshiAMD left a comment

Choose a reason for hiding this comment

tlylt commented Sep 7, 2022

all-contributors-release-bot commented Sep 7, 2022

tlylt commented Sep 7, 2022

tenshiAMD commented Sep 7, 2022 • edited

tlylt commented Sep 7, 2022

tenshiAMD commented Sep 7, 2022

tenshiAMD commented Sep 7, 2022

tenshiAMD commented Sep 7, 2022

tlylt commented Sep 8, 2022

hpierre74 commented Jan 8, 2022 •

edited

hpierre74 commented Jan 8, 2022 •

edited

tlylt commented Aug 16, 2022 •

edited

tenshiAMD left a comment •

edited

tenshiAMD commented Sep 7, 2022 •

edited