Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: add image size to avatar url to improve performance #269

Merged
merged 3 commits into from
Jun 28, 2020
Merged

perf: add image size to avatar url to improve performance #269

merged 3 commits into from
Jun 28, 2020

Conversation

pavelloz
Copy link
Contributor

Fixes all-contributors/all-contributors#409

What:

Why:

How:

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@Berkmann18 Berkmann18 changed the title Add image size to avatar url to improve performance perf: add image size to avatar url to improve performance Jun 17, 2020
Berkmann18
Berkmann18 approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@Berkmann18 Berkmann18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@all-contributors Please add @pavelloz for code

@Berkmann18
Copy link
Member

I wonder why the validate_and_deploy check is still hanging 🤔.

@pavelloz
Copy link
Contributor Author

Hmmm, lets try turning it off and on again ;-)

@pavelloz pavelloz closed this Jun 23, 2020
@pavelloz pavelloz reopened this Jun 23, 2020
@Berkmann18 Berkmann18 merged commit fc2d05e into all-contributors:master Jun 28, 2020
@Berkmann18
Copy link
Member

@all-contributors Please add @pavelloz for code

@allcontributors allcontributors bot mentioned this pull request Jun 28, 2020
Merged
@allcontributors
Copy link
Contributor

@Berkmann18

I've put up a pull request to add @pavelloz! 🎉

@all-contributors-release-bot
Copy link
Member

🎉 This PR is included in version 6.16.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@pavelloz pavelloz deleted the add-avatar-size-to-url branch June 28, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Berkmann18 Berkmann18 Berkmann18 approved these changes

Assignees
No one assigned
Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avatar size
3 participants
@pavelloz @Berkmann18 @all-contributors-release-bot