Fix clippy lints #23
Merged
Fix clippy lints #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LineParser::substitution_data is already `&mut` so there's no need to create a reference before passing. Addresses a clippy issue.
The #[non_exhaustive] attribute achieves the same compatibility reservations as a dummy variant without requiring code to handle that variant. Addresses a clippy issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
annotation ondotenvy::Error` enumThe second one is technically an incompatible API change. However, the whole point of the
__Nonexhaustivevariant pattern is to get callers to include a wildcard branch when matching, so you could argue it doesn't require a semver bump: anyone referring to that variant explicitly was doing it wrong. But I don't know if that's the normal expectation; this pattern is new to me.