Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load saml from responses #52

Merged
merged 6 commits into from
Sep 10, 2018
Merged

Load saml from responses #52

merged 6 commits into from
Sep 10, 2018

Commits on Sep 10, 2018

  1. Load saml from responses

    @johananl
    jspc authored and johananl committed Sep 10, 2018
    Configuration menu
    Copy the full SHA
    c331642 View commit details
    Browse the repository at this point in the history

  2. Remove ARNs from config, cli

    @johananl
    jspc authored and johananl committed Sep 10, 2018
    Configuration menu
    Copy the full SHA
    29be711 View commit details
    Browse the repository at this point in the history

  3. Ensure README reflects reality

    @johananl
    jspc authored and johananl committed Sep 10, 2018
    Configuration menu
    Copy the full SHA
    2d116e3 View commit details
    Browse the repository at this point in the history

  4. Handle empty role value in SAML 

    Wrong OneLogin config can lead to a role attribute with an empty
value in the SAML assertion. Example:

<saml:Attribute NameFormat="urn:oasis:names:tc:SAML:2.0:attrname-format:basic" Name="https://aws.amazon.com/SAML/Attributes/Role">
    <saml:AttributeValue xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:type="xs:string"/>
</saml:Attribute>

We check for empty value before parsing ARNs to avoid index error.
    @johananl
    johananl committed Sep 10, 2018
    Configuration menu
    Copy the full SHA
    0f1b7a0 View commit details
    Browse the repository at this point in the history

  5. Run dep ensure 

    The following dependency is missing: github.com/edaniels/go-saml
    @johananl
    johananl committed Sep 10, 2018
    Configuration menu
    Copy the full SHA
    d97f6ec View commit details
    Browse the repository at this point in the history

  6. Refactor role selection 

    Enumerate roles starting at 1 instead of 0. This is more
human-friendly and consistent with MFA device selection behavior.
    @johananl
    johananl committed Sep 10, 2018
    Configuration menu
    Copy the full SHA
    55607b9 View commit details
    Browse the repository at this point in the history