Update tests #4
Update tests #4
Conversation
| @@ -0,0 +1,12 @@ | |||
| github.com/davecgh/go-spew v1.1.0 h1:ZDRjVQ15GmhC3fiQ8ni8+OwkZQO4DARzQgrnXU1Liz8= | |||
There was a problem hiding this comment.
ci add ci
Ci add cache
|
@mrsndmn Thank you for your PR! I will review it tomorrow. It looks promising. |
cdb_test.go
Outdated
| if reader.Size() != 7 { | ||
| t.Errorf("Expected size %d, got %d", 7, reader.Size()) | ||
| // generate test records | ||
| const testRecordsCount = 10 |
There was a problem hiding this comment.
Do we need this const here? I guess we can remove it
cdb_test.go
Outdated
| {"key7", "value7"}, | ||
| } | ||
| writer := suite.getCDBWriter() | ||
| defer writer.Close() |
There was a problem hiding this comment.
We should check the result of Close function
There was a problem hiding this comment.
Good point! Thank you!
cdb_test.go
Outdated
| defer os.Remove("test.cdb") | ||
| func (suite *CDBTestSuite) TestShouldReturnNilOnNonExistingKeys() { | ||
| writer := suite.getCDBWriter() | ||
| writer.Close() |
There was a problem hiding this comment.
Please add here check suite.Nilf
cdb_test.go
Outdated
| if reader.Size() != 7 { | ||
| t.Errorf("Expected size %d, got %d", 7, reader.Size()) | ||
| // generate test records | ||
| const testRecordsCount = 10 |
cdb_test.go
Outdated
| {"key7", "value7"}, | ||
| } | ||
| writer := suite.getCDBWriter() | ||
| defer writer.Close() |
There was a problem hiding this comment.
Good point! Thank you!
cdb_test.go
Outdated
| defer os.Remove("test.cdb") | ||
| func (suite *CDBTestSuite) TestShouldReturnNilOnNonExistingKeys() { | ||
| writer := suite.getCDBWriter() | ||
| writer.Close() |
|
I also added |
It is better to create a separate PR:) Thank you for your work! |
I've refactored tests with testify. Seems it looks nice now.
Unfortunately, I cant do anything with benchmarks. There is no support of benchmarks in
testify/suite.