Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix read benchmarks #201

Merged
merged 1 commit into from
Jan 20, 2020
Merged

fix read benchmarks #201

merged 1 commit into from
Jan 20, 2020

Conversation

janisz
Copy link
Collaborator

@janisz janisz commented Jan 20, 2020

Number of shards in read benchmarks is always set to 1024 instead of parametrized value.

This was broken since Go 1.7 90098c5#r36883572

Number of shards in `read` benchmarks is always set to 1024 instead of parametrized value.
janisz referenced this pull request Jan 20, 2020
enhancement: added new data struct Response, which will be returned when
calling GetWithInfo(). Caller can use this Response to check the status
of the Entry, whether its Expired or not. Default '0' means its still
in use.
Copy link
Collaborator

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohwow

@cristaloleg cristaloleg merged commit 7090562 into allegro:master Jan 20, 2020
flisky pushed a commit to flisky/bigcache that referenced this pull request May 7, 2020
Number of shards in `read` benchmarks is always set to 1024 instead of parametrized value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants