Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset full to false when pop from bytes queue #223

Merged
merged 1 commit into from
May 29, 2020

Conversation

WideLee
Copy link
Contributor

@WideLee WideLee commented May 29, 2020

When byte queue is full, it will set queue.full=true but when evict and pop entry from queue, it does not set to false again. It causes bigcache cannot insert new entries once the queue is full.

This commit set queue.full=false when pop entry from queue, and add a test case which failed in current master ccdbc60 and passed in this commit.

Related to issue #214
And it seems the same problem in Pull Request #218

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2020

Codecov Report

Merging #223 into master will decrease coverage by 1.52%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
- Coverage   90.61%   89.09%   -1.53%     
==========================================
  Files          15       15              
  Lines         714      715       +1     
==========================================
- Hits          647      637      -10     
- Misses         58       66       +8     
- Partials        9       12       +3     
Impacted Files Coverage Δ
queue/bytes_queue.go 88.80% <100.00%> (+0.09%) ⬆️
shard.go 86.52% <0.00%> (-4.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccdbc60...8d7fc3a. Read the comment docs.

Copy link
Collaborator

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@WideLee WideLee requested a review from cristaloleg May 29, 2020 13:22
Copy link
Collaborator

@siennathesane siennathesane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for bug hunting!

@siennathesane siennathesane merged commit fbc4902 into allegro:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants