Reset full to false when pop from bytes queue #223
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When byte queue is full, it will set
queue.full=true
but when evict and pop entry from queue, it does not set to false again. It causes bigcache cannot insert new entries once the queue is full.This commit set
queue.full=false
when pop entry from queue, and add a test case which failed in current master ccdbc60 and passed in this commit.Related to issue #214
And it seems the same problem in Pull Request #218