Introduced HdrHistogram-based metrics reservoir #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristaloleg
approved these changes
Jul 8, 2019
hermes-common/src/main/java/pl/allegro/tech/hermes/common/metric/MetricsReservoirType.java
Show resolved
Hide resolved
druminski
reviewed
Jul 8, 2019
|
|
||
| * `exponentially_decaying` - exponentially decaying reservoir (previous version, currently default) | ||
| * `hdr` - HdrHistogram–based reservoir | ||
|
|
There was a problem hiding this comment.
I would add an information why it’s worth to consider using hdr histogram. Something like: 'HdrHistogram-based reservoir has much less memory footprint than exponentially decaying. Because of this GC in Hermes has less job to do which leads to better Hermes performance. In the near future HDR will be default Hermes metrics reservoir.'
druminski
approved these changes
Jul 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.