Configure log format #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| config.setLogLevel() | ||
|
|
||
| if err != nil { | ||
| return config, err |
There was a problem hiding this comment.
I think we should return nil, err here as config is already defined as Config{}
janisz
force-pushed
the
configure_logger
branch
from
4ac1248
to
71f8c4e
Compare
|
👍 |
janisz
force-pushed
the
configure_logger
branch
3 times, most recently
from
615eccc
to
da49243
Compare
|
We have Marathon password leak in logs. I fixed it and also make logs more consistent every log (if possible) has |
janisz
force-pushed
the
configure_logger
branch
from
da49243
to
1de0ea5
Compare
janisz
force-pushed
the
configure_logger
branch
from
1de0ea5
to
02e8677
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.