Create alias types for Id #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return string(id) | ||
| } | ||
|
|
||
| func (id Id) String() string { |
There was a problem hiding this comment.
moving it closer to the type definition (just below it) would make it nicer to read. ❤️
|
great! |
janisz
force-pushed
the
destringify
branch
5 times, most recently
from
56ae493
to
9d5dc54
Compare
Use apps.Id insted of string Use tasks.Id instead of string Move apps.Id to tasks.AppId Add docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our code is Stringly Typed. I added ID alias type for strings.