No service matching task id, change log level to warning. #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janisz
suggested changes
Apr 11, 2017
consul/consul.go
Outdated
| @@ -203,7 +203,8 @@ func (c *Consul) DeregisterByTask(taskID apps.TaskID) error { | |||
| if err != nil { | |||
| return err | |||
| } else if len(services) == 0 { | |||
| return fmt.Errorf("Couldn't find any service matching task id %s", taskID) | |||
| log.Warningf("Couldn't find any service matching task id %s", taskID) | |||
There was a problem hiding this comment.
put task ID in WithField("Id", taskID)
tomez
force-pushed
the
fix/taskid-loglevel
branch
from
1f8ac80
to
2a9b403
Compare
janisz
suggested changes
Apr 11, 2017
consul/consul.go
Outdated
| @@ -203,7 +203,10 @@ func (c *Consul) DeregisterByTask(taskID apps.TaskID) error { | |||
| if err != nil { | |||
| return err | |||
| } else if len(services) == 0 { | |||
| return fmt.Errorf("Couldn't find any service matching task id %s", taskID) | |||
| log.WithFields( | |||
There was a problem hiding this comment.
it can be shortened to .WithField("Id", taskID)
tomez
force-pushed
the
fix/taskid-loglevel
branch
from
2a9b403
to
44a1ff9
Compare
janisz
approved these changes
Apr 11, 2017
dankraw
approved these changes
Apr 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.