Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to streamer #244

Merged
merged 1 commit into from
Jun 20, 2017
Merged

Add tests to streamer #244

merged 1 commit into from
Jun 20, 2017

Conversation

janisz
Copy link
Contributor

@janisz janisz commented Jun 19, 2017

No description provided.

@janisz janisz requested a review from tomez June 19, 2017 15:05
@coveralls
Copy link

Coverage Status

Coverage increased (+2.6%) to 89.38% when pulling 29601de on add_tests_to_streamer into 6151298 on master.

tomez
tomez approved these changes Jun 20, 2017
View reviewed changes
marathon/streamer_test.go Outdated
"github.com/stretchr/testify/assert"
)

func TestStreamer_RecoverShouldReturnWhenCantStart(t *testing.T) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestStreamer_RecoverShouldReturnWhenCantStart -> TestStreamer_RecoverShouldReturnErrorWhenCantStart

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@coveralls
Copy link

Coverage Status

Coverage increased (+2.6%) to 89.374% when pulling 230508c on add_tests_to_streamer into 9732f56 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.6%) to 89.374% when pulling 230508c on add_tests_to_streamer into 9732f56 on master.

@janisz janisz merged commit e36ce2d into master Jun 20, 2017
@janisz janisz deleted the add_tests_to_streamer branch June 20, 2017 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomez tomez tomez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janisz @coveralls @tomez