Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't sync TASK_KILLING services #266

Merged
merged 2 commits into from
Oct 2, 2017
Merged

Don't sync TASK_KILLING services #266

merged 2 commits into from
Oct 2, 2017

Conversation

cynial
Copy link
Contributor

@cynial cynial commented Sep 29, 2017 •
edited by janisz
Loading

Fixes: #265

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.066% when pulling 08e902c on cynial:master into d9bfb8f on allegro:master.

janisz
janisz suggested changes Sep 29, 2017
View reviewed changes
Copy link
Contributor

@janisz janisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you extend tests for this change? Best place to do it will be apps/task_test.go.

@cynial
Copy link
Contributor Author

cynial commented Sep 30, 2017

I'll do it.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.066% when pulling b5a348c on cynial:master into d9bfb8f on allegro:master.

@janisz
Copy link
Contributor

janisz commented Oct 1, 2017

LGTM. I'll test it manually and merge.

@janisz janisz merged commit 33394b5 into allegro:master Oct 2, 2017
@janisz
Copy link
Contributor

janisz commented Oct 2, 2017

@cynial Thanks!

@janisz janisz mentioned this pull request Nov 15, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janisz janisz janisz approved these changes

Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cynial @coveralls @janisz