Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37 | Configure consul timeouts #44

Merged
merged 1 commit into from
Jan 29, 2016

Conversation

janisz
Copy link
Contributor

@janisz janisz commented Jan 28, 2016

No description provided.

@@ -85,6 +85,11 @@ func (a *ConcurrentAgents) createAgent(host string) (*consulapi.Client, error) {
config.Scheme = "https"
}

if a.config.Timeout != 0 {
log.Debugf("Seting timeout to %s", a.config.Timeout.String())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo Seting -> Setting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@janisz janisz force-pushed the configure_consul_request_timeout branch from 8e143dc to 09d1411 Compare January 28, 2016 14:58
@@ -70,6 +70,7 @@ consul-ssl-cert | | Path to an SSL client certifica
consul-ssl-verify | `true` | Verify certificates when connecting via SSL
consul-token | | The Consul ACL token
consul-tag | `marathon` | Common tag name added to every service registered in Consul, should be unique for every Marathon-cluster connected to Consul
consul-timeout | `1 s` | Max request duration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 s => 1s (no space)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@janisz janisz force-pushed the configure_consul_request_timeout branch 2 times, most recently from 9e81370 to 27f2060 Compare January 28, 2016 15:07
@janisz janisz force-pushed the configure_consul_request_timeout branch from 27f2060 to 853a87c Compare January 28, 2016 15:15
@dankraw
Copy link
Contributor

dankraw commented Jan 28, 2016

👍

janisz added a commit that referenced this pull request Jan 29, 2016
@janisz janisz merged commit bf93d8d into master Jan 29, 2016
@janisz janisz deleted the configure_consul_request_timeout branch January 29, 2016 08:28
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 95.081% when pulling 09d1411 on configure_consul_request_timeout into 25f4d3d on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants