Fixes #59 | Get only consul apps from marathon #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,7 +15,7 @@ import ( | |||
| ) | |||
|
|
|||
| type Marathoner interface { | |||
| Apps() ([]*apps.App, error) | |||
| AppsWithLabel(label string) ([]*apps.App, error) | |||
There was a problem hiding this comment.
Personally, I would prefer something less technical in this api, like ManagedApps() or ConsulApps() which would be implemented as private return appsWithLabel(apps.MARATHON_CONSUL_LABEL). We wouldn't have to pass that "consul" label value everywhere in the project.
We could go further and rename app.IsConsulApp() to app.IsManagedApp() if necessary.
|
👍 but see comment :> |
janisz
force-pushed
the
Fixes#59_filter_apps_on_marathon_side
branch
from
6ab3118
to
b3aaec3
Compare
|
Renamed |
|
👍 |
janisz
added a commit
that referenced
this pull request
Feb 22, 2016
…side Fixes #59 | Get only consul apps from marathon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.