Mark cert expired tasks as killed instead of failed #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't mark task where the certificate expires as a failed task, because it was explicitly killed by the executor and it wasn't the tasks fault that it had to die.
janisz
approved these changes
Jan 5, 2018
ojagodzinski
reviewed
Jan 5, 2018
| unhealthy := false | ||
| info := state.OptionalInfo{Healthy: &unhealthy, Message: &event.Message} | ||
| e.stateUpdater.UpdateWithOptions(taskInfo.GetTaskID(), mesos.TASK_RUNNING, info) | ||
| log.WithFields(log.Fields{"TaskID": taskInfo.GetTaskID(), "Reason": event.Message}).Info("Killing task") |
There was a problem hiding this comment.
maybe add reason why task is killed?
There was a problem hiding this comment.
There already i in the Reason field, because of
e.events <- Event{Type: FailedDueToExpiredCertificate, Message: "Certificate expired"}There was a problem hiding this comment.
yeah but the one you pointed is sent to Marathon and the one I pointed is a local executor log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't mark task where the certificate expires as
a failed task, because it was explicitly killed by the executor
and it wasn't the tasks fault that it had to die.