Functions #19
Merged
Functions #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzukow
reviewed
Oct 13, 2016
|
|
||
| @Override | ||
| public CompletableFuture<?> getValue(EvalContext context) { | ||
| return null; |
| if (fun instanceof OpelAsyncFunction) { | ||
| return ((OpelAsyncFunction) fun).apply(argsGroup.getListOfValues(context)); | ||
| } | ||
| throw new OpelException("Can use '" + fun.getClass().getSimpleName() + "' as a function"); |
pawel-piecyk
suggested changes
Oct 13, 2016
| } | ||
|
|
||
| Rule FunctionBody() { | ||
| return FirstOf( |
There was a problem hiding this comment.
Why not:
return FirstOf(
Expression(),
Sequence("{ ", Body(), "} "), push(pop()));
?
There was a problem hiding this comment.
enough is
return FirstOf(
Expression(),
Sequence("{ ", Body(), "} "));
| "val fun = (x, y) -> x*y; fun(2, 3, 4, 5)" || 6 | ||
| } | ||
|
|
||
| def 'should avoid access to val defined in function outsite its'() { |
There was a problem hiding this comment.
You can add similar test showing that local val declaration doesn't change outer val e.g.
val x = 10;
val y = (a) -> {
val x = 5;
x * a;
}(5)
assert x == 10
|
|
||
| then: | ||
| def ex = thrown ExecutionException | ||
| ex.cause instanceof OpelException |
There was a problem hiding this comment.
I don't like the fact that we only check if OpelException was thrown while cause is completely ignored. I can modify the first case to val fun = x -> x*x; fun(4) * 'a' and this test will pass. Maybe it's a good time to introduce hierarchy of exceptions or check for sufficient messages in tests.
There was a problem hiding this comment.
exception hierarchy sound good.
I can do this in separate PR
rzukow
approved these changes
Oct 13, 2016
rzukow
approved these changes
Oct 14, 2016
pawel-piecyk
approved these changes
Oct 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.