Maps instantation #23
Conversation
rzukow
force-pushed
the
mapsInstantation
branch
from
848b7c5
to
e68f426
Compare
rzukow
force-pushed
the
mapsInstantation
branch
from
e68f426
to
d5d5258
Compare
| @Override | ||
| public CompletableFuture<?> getValue(EvalContext context) { | ||
| return FutureUtil.sequence(pairs.getPairs().stream() | ||
| .map(pair -> pair.getKey().getValue(context) |
There was a problem hiding this comment.
what about add method toEntry in PairNode class? or a method on PairsListNode?
| } | ||
|
|
||
| @Override | ||
| public CompletableFuture<?> getValue(EvalContext context) { |
There was a problem hiding this comment.
CompletableFuture<?> -> CompletableFuture<Map<Object, Object>>
| "{x:2}" || [x: 2] | ||
| "({'x': 2 })" || [x: 2] | ||
| "{'x': 2, 'y':3 }" || [x: 2, y: 3] | ||
| "{(1+1): 2, 'y':3 }" || [(BigDecimal.valueOf(2)): 2, y: 3] |
There was a problem hiding this comment.
- BigDecimal is default numeric type in groovy.
- this case should be in 'should instantiate map with expression key defined in #input' spec.
There was a problem hiding this comment.
Ad. 1. it doesn't work without converting to BigDecimal
Ad. 2.fixed
| input || expResult | ||
| "{}" || [:] | ||
| "{'x':2}" || [x: 2] | ||
| "{x:2}" || [x: 2] |
There was a problem hiding this comment.
what if val x is defined? do we need notation without '?
There was a problem hiding this comment.
good question, x will be parsed as identifier, no matter if value x exists.
There was a problem hiding this comment.
notation without ' is a nice syntactic sugar IMO
| @@ -34,6 +69,7 @@ class OpelEngineMapIntegrationSpec extends Specification { | |||
|
|
|||
| where: | |||
| input || expResult | |||
| "{x:2, y:5}.x" || 2 | |||
There was a problem hiding this comment.
add some test when map is assigned to some val. Now we test access to anonymous map and map from context.
No description provided.