Simplify SumOperatorExpressionNode #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfij
reviewed
Apr 18, 2018
| if (node == null) { | ||
| return BigDecimal.ZERO; | ||
| } | ||
| if ((node instanceof BigDecimal || node instanceof String)) { |
tfij
reviewed
Apr 18, 2018
| if (left == null && right == null) { | ||
| return BigDecimal.ZERO; | ||
| if (left == null) { | ||
| return node(right); |
There was a problem hiding this comment.
how about return nullPlus(right);
janisz
force-pushed
the
simplify_addition
branch
from
b4f4879
to
d59b0d4
Compare
|
@tfij Please rerun the tests |
rzukow
approved these changes
May 8, 2018
pawel-piecyk
approved these changes
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially for @tfij 🙈