Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components for scan command - added Ethernet and Memory. #21

Merged
merged 3 commits into from
Jul 12, 2016
Merged

Components for scan command - added Ethernet and Memory. #21

merged 3 commits into from
Jul 12, 2016

Conversation

xor-xor
Copy link
Contributor

@xor-xor xor-xor commented Jul 5, 2016

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.3%) to 63.891% when pulling 00ed00b on xor-xor:components into e9a18a2 on allegro:develop.

mkurek
mkurek reviewed Jul 6, 2016
View reviewed changes
actions.go
// to exclude such EthernetComponents from diff.Delete.
// When IP address is marked as "exposed in DHCP" in Ralph, then the only
// way to delete Ethernet associated with its MAC address is through a
// suitable transition from Ralph's GUI (i.e., it is not possible via REST
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

transitions are exposed in API as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the info, I'll update this comment.

Copy link
Contributor

@vi4m vi4m Jul 7, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you print out this explanation to the user ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, as a warning.

@mkurek
Copy link

mkurek commented Jul 6, 2016

🆗

@coveralls
Copy link

Coverage Status

Coverage increased (+3.3%) to 63.891% when pulling eddac75 on xor-xor:components into e9a18a2 on allegro:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.3%) to 63.891% when pulling e2d7d9e on xor-xor:components into e9a18a2 on allegro:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.3%) to 63.891% when pulling e2d7d9e on xor-xor:components into e9a18a2 on allegro:develop.

This was referenced Jul 8, 2016
Merged
Merged
@vi4m
Copy link
Contributor

vi4m commented Jul 12, 2016

LGTM

@vi4m
Copy link
Contributor

vi4m commented Jul 12, 2016

Remember to use new commit log standards we discussed this week and 2 weeks ago - "Add" form instead of Added, Fix instead of Fixed and so on

@xor-xor xor-xor merged commit d97ec2d into allegro:develop Jul 12, 2016
@xor-xor xor-xor deleted the components branch July 12, 2016 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xor-xor @coveralls @mkurek @vi4m