Merge pull request #2307 from szok/dns-form-errors

DNS change get_domain method
allegro · Mar 21, 2016 · f943226 · f943226
2 parents 2707e8e + f20d509
commit f943226
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/ralph/dns/dnsaas.py b/src/ralph/dns/dnsaas.py
@@ -99,20 +99,19 @@ def update_dns_records(self, record):
         return True
 
     @cache()
-    def get_domain(self, record):
+    def get_domain(self, domain_name):
         """
         Return domain URL base on record name.
 
         Args:
-            record: Cleaned data from formset
+            domain_name: Domain name
 
         Return:
             Domain URL from API or False if not exists
         """
-        domain_name = record['name'].split('.', 1)
         url = urljoin(
             settings.DNSAAS_URL, 'api/domains/?'.format(
-                urlencode([('name', domain_name[-1])])
+                urlencode([('name', domain_name)])
             )
         )
         result = self.get_api_result(url)
@@ -133,7 +132,8 @@ def create_dns_records(self, record):
         """
 
         url = urljoin(settings.DNSAAS_URL, 'api/records/')
-        domain = self.get_domain(record)
+        domain_name = record['name'].split('.', 1)
+        domain = self.get_domain(domain_name[-1])
         if not domain:
             logger.error(
                 'Domain not found for record {}'.format(record)