Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation Service in CMDB. #1201

Merged

Conversation

quamilek
Copy link
Member

Preventing a change Service status in from active to another, when Service has connected devices.
Changes were made in the editing form and api.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.29%) when pulling f96ea0e on quamilek:cmdb-services-api-validation into c07ae88 on allegro:develop.

@xor-xor
Copy link
Contributor

xor-xor commented Nov 24, 2014

LGTM, with one exception - what about extracting these two ifs (i.e. this and this)
to a common function..?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) when pulling cdb1b8d on quamilek:cmdb-services-api-validation into c07ae88 on allegro:develop.

@xor-xor
Copy link
Contributor

xor-xor commented Nov 24, 2014

🆗

@andrzej-jankowski andrzej-jankowski merged commit 34049ce into allegro:develop Nov 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants